Delete copy_memory function #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<[_]>::copy_from_slice` is a better replacement Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
|
bors: r+ |
Dylan-DPC-zz
approved these changes
Mar 19, 2018
bors bot
added a commit
that referenced
this pull request
Mar 19, 2018
175: Delete copy_memory function r=Dylan-DPC a=kinggoesgaming
<!--
As we are working towards a stable version of uuid, we require that you
open an issue, before submitting a pull request. If the pull request is
imcomplete, prepend the Title with WIP:
-->
**I'm submitting a ...**
- [ ] bug fix
- [ ] feature enhancement
- [x] deprecation or removal
- [x] refactor
# Description
Replace `uuid::copy_memory` with `<[_]>::copy_from_slice`
# Motivation
`core` already provides a good optimized version of `slice` copying function, so we dont need to create our own duplicate code.
# Tests
Our tests and benchmarks are running good, other than one or two runs which suggest a 1-2 nanosecond slowdown.
# Related Issue(s)
#173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
Replace
uuid::copy_memorywith<[_]>::copy_from_sliceMotivation
corealready provides a good optimized version ofslicecopying function, so we dont need to create our own duplicate code.Tests
Our tests and benchmarks are running good, other than one or two runs which suggest a 1-2 nanosecond slowdown.
Related Issue(s)
#173