Add Nil variant #181
Merged
Add Nil variant #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
kinggoesgaming
added
Type:Enhancement
breaking
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Dylan-DPC-zz
previously approved these changes
Mar 21, 2018
KodrAus
reviewed
Mar 22, 2018
src/lib.rs
Outdated
| @@ -151,6 +151,8 @@ pub type UuidBytes = [u8; 16]; | |||
| /// The version of the UUID, denoting the generating algorithm. | |||
| #[derive(Debug, PartialEq, Copy, Clone)] | |||
| pub enum UuidVersion { | |||
| /// Special case for `nil` [`struct.Uuid.html`]. | |||
There was a problem hiding this comment.
What do we have the [struct.Uuid.html] here for? Does this render in the docs as struct.Uuid.html?
There was a problem hiding this comment.
Woops I forgot to link it will fix it ASAP
There was a problem hiding this comment.
That was supposed to be Uuid
There was a problem hiding this comment.
@KodrAus fixed.. can you approve
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
kinggoesgaming
dismissed stale reviews from KodrAus and Dylan-DPC-zz
via
8b5c74e
Dylan-DPC-zz
approved these changes
Mar 25, 2018
KodrAus
approved these changes
Mar 25, 2018
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Mar 25, 2018
181: Add Nil variant r=Dylan-DPC a=kinggoesgaming
<!--
As we are working towards a stable version of uuid, we require that you
open an issue, before submitting a pull request. If the pull request is
imcomplete, prepend the Title with WIP:
-->
**I'm submitting a ...**
- [ ] bug fix
- [x] feature enhancement
- [ ] deprecation or removal
- [ ] refactor
# Description
Adds `Nil` variant to the `UuidVersion`.
# Motivation
`nil` `Uuid`, containing all zeros, is a valid `Uuid`, as per the specification. This will allow users doing pattern matching to explicitly check for it.
# Tests
Updated `test_nil` to ensure that
# Related Issue(s)
closes #133
supersedes #176
4 tasks
bors bot
added a commit
that referenced
this pull request
Mar 28, 2018
188: Add UuidVersion to the prelude r=Dylan-DPC a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description Add `UuidVersion` to the prelude. # Motivation With #181, `UuidVersion` is now stable, and as such can be used as part of the `prelude` # Tests N/A # Related Issue(s) #181, #166
bors bot
added a commit
that referenced
this pull request
Mar 28, 2018
188: Add UuidVersion to the prelude r=kinggoesgaming a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description Add `UuidVersion` to the prelude. # Motivation With #181, `UuidVersion` is now stable, and as such can be used as part of the `prelude` # Tests N/A # Related Issue(s) #181, #166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
Adds
Nilvariant to theUuidVersion.Motivation
nilUuid, containing all zeros, is a validUuid, as per the specification. This will allow users doing pattern matching to explicitly check for it.Tests
Updated
test_nilto ensure thatRelated Issue(s)
closes #133
supersedes #176