Allow playground defaults #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Dylan-DPC-zz
approved these changes
Mar 30, 2018
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Mar 30, 2018
189: Allow playground defaults r=Dylan-DPC a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description Allow compatibility with play.integer32.com and play.rust-lang.org # Motivation Allows people to use `uuid` in interactive code snippets # Tests Current tests passing # Related Issue(s) Supercedes #155
KodrAus
reviewed
Mar 31, 2018
| @@ -402,12 +402,30 @@ impl Uuid { | |||
| /// Note that not all versions can be generated currently and `None` will be | |||
| /// returned if the specified version cannot be generated. | |||
| /// | |||
| /// To generate a random UUID (`UuidVersion::Md5`), then the `v3` | |||
There was a problem hiding this comment.
I think we should note in the docs that we're generating these random uuids off the well-known dns namespace uuid.
There was a problem hiding this comment.
Hmm actually we probably don't need to, since we have enough randomness in the hash we jam into the uuid the base shouldn't matter so much.
LinusU
pushed a commit
to LinusU/uuid
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
Allow compatibility with play.integer32.com and play.rust-lang.org
Motivation
Allows people to use
uuidin interactive code snippetsTests
Current tests passing
Related Issue(s)
Supercedes #155