introduce UuidError for general Uuid use #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
kinggoesgaming
added
Type:Refactor
breaking
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
kinggoesgaming
changed the title
Dylan-DPC-zz
approved these changes
Jul 24, 2018
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2018
284: introduce UuidError for general Uuid use r=Dylan-DPC a=kinggoesgaming **I'm submitting a(n)** feature, refactor # Description * Introduce a `::UuidError` type. * Change signature of `::Uuid::from_fields`, `::Uuid::new_v1` and `::Uuid::from_bytes` to use the new error type. This now splits the `Uuid` creation types into 3 categories: * those which have no errors for creating * those which throw errors based around parsing (currently `ParseError`) * those which throw errors based around bytes (`UuidError`) # Motivation `ParseError` is oriented around parsing uuid strings. However, that error type does not bode well functions that are accepting bytes. # Tests All current tests pass with the signature change. No new tests added # Related Issue(s) closes #281 Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a(n) feature, refactor
Description
::UuidErrortype.::Uuid::from_fields,::Uuid::new_v1and::Uuid::from_bytesto use the new error type.This now splits the
Uuidcreation types into 3 categories:ParseError)UuidError)Motivation
ParseErroris oriented around parsing uuid strings. However, that error type does not bode well functions that are accepting bytes.Tests
All current tests pass with the signature change. No new tests added
Related Issue(s)
closes #281