Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from winapi to windows-rs in examples #622

Closed
wants to merge 4 commits into from
Closed

Migrate from winapi to windows-rs in examples #622

wants to merge 4 commits into from

Conversation

sn99
Copy link
Contributor

@sn99 sn99 commented Sep 12, 2022

I'm submitting a(n) (deprecation|refactor|removal)

Description

Migrate from winapi to windows-rs for the following:

  1. Winapi is no longer actively maintained (last commit was 9 months ago as of now and 2nd last around 2 years ago) compared to last commit to windows-rs as of few days ago.
  2. windows-rs is the official Rust crate for Windows by Microsoft and is supposed to be providing a natural and idiomatic way for Rust developers to call Windows APIs. Some crates like socket2 have already migrated to it.

Related Issue(s)

None

@KodrAus
Copy link
Member

KodrAus commented Sep 23, 2022

Thanks for doing this @sn99! This looks good to me. If you rebase on main that should fix up that build failure. We already bumped our minimum supported toolchain up to 1.57.0.

@sn99
Copy link
Contributor Author

sn99 commented Sep 23, 2022

Ah, I just saw the build error "windows v0.39.0" cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.57.0

Apparently windows has minimum of 1.59 and windows-sys is 1.49, I am thinking of changing from windows to windows-sys ?

@sn99
Copy link
Contributor Author

sn99 commented Sep 23, 2022

I will open another one, ggs to commit history idk what I did

@sn99 sn99 closed this Sep 23, 2022
@sn99
Copy link
Contributor Author

sn99 commented Sep 24, 2022

Opened #626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants