Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wasm tests not running due to incorrect attribute target #688

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

kmusick
Copy link
Contributor

@kmusick kmusick commented Jun 22, 2023

Fixes #687 by replacing

target = "wasm32-unknown-unknown"

with

all(target_arch = "wasm32", target_vendor = "unknown", target_os = "unknown")

Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmusick!

@KodrAus KodrAus merged commit bf7fe91 into uuid-rs:main Jun 26, 2023
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Jun 27, 2023
Bumps uuid from 1.3.4 to 1.4.0.

Release notes
Sourced from uuid's releases.

1.4.0
What's Changed

Fixed wasm tests not running due to incorrect attribute target by @​kmusick in uuid-rs/uuid#688
Fixing issue with Cloudflare Workers and wasm32-unknown-unknown when using now() by @​kmusick in uuid-rs/uuid#690
Add borsh support by @​grovesNL in uuid-rs/uuid#686
Fix some timestamp generation by @​KodrAus in uuid-rs/uuid#691
Prepare for 1.4.0 release by @​KodrAus in uuid-rs/uuid#692

New Contributors

@​kmusick made their first contribution in uuid-rs/uuid#688
@​grovesNL made their first contribution in uuid-rs/uuid#686

Full Changelog: uuid-rs/uuid@1.3.4...1.4.0



Commits

0fc3101 Merge pull request #692 from uuid-rs/cargo/1.4.0
d9f72db prepare for 1.4.0 release
cb2aac0 Merge pull request #691 from uuid-rs/fix/timestamp-gen
0cb9232 add missing wasm import
cb80ba2 run fmt
8babf97 add missing wasm test attr
759c971 fix a warning in arbitrary support
646bd98 wrap rather than overflow timestamps
7da3f69 remove dbg call from wasm-based timestamp
952f75f Merge pull request #686 from pod2co/borsh
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jun 29, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [uuid](https://github.com/uuid-rs/uuid) | dependencies | minor | `1.3.4` -> `1.4.0` |

---

### Release Notes

<details>
<summary>uuid-rs/uuid (uuid)</summary>

### [`v1.4.0`](https://github.com/uuid-rs/uuid/releases/tag/1.4.0)

[Compare Source](uuid-rs/uuid@1.3.4...1.4.0)

#### What's Changed

-   Fixed wasm tests not running due to incorrect attribute target by [@&#8203;kmusick](https://github.com/kmusick) in uuid-rs/uuid#688
-   Fixing issue with Cloudflare Workers and wasm32-unknown-unknown when using now() by [@&#8203;kmusick](https://github.com/kmusick) in uuid-rs/uuid#690
-   Add `borsh` support by [@&#8203;grovesNL](https://github.com/grovesNL) in uuid-rs/uuid#686
-   Fix some timestamp generation by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#691
-   Prepare for 1.4.0 release by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#692

#### New Contributors

-   [@&#8203;kmusick](https://github.com/kmusick) made their first contribution in uuid-rs/uuid#688
-   [@&#8203;grovesNL](https://github.com/grovesNL) made their first contribution in uuid-rs/uuid#686

**Full Changelog**: uuid-rs/uuid@1.3.4...1.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMyIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4zIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1948
Reviewed-by: crapStone <crapstone01@gmail.com>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
akrantz01 referenced this pull request in akrantz01/lers Jul 17, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [uuid](https://togithub.com/uuid-rs/uuid) | dependencies | minor |
`1.3.4` -> `1.4.1` |

---

### Release Notes

<details>
<summary>uuid-rs/uuid (uuid)</summary>

### [`v1.4.1`](https://togithub.com/uuid-rs/uuid/releases/tag/1.4.1)

[Compare
Source](https://togithub.com/uuid-rs/uuid/compare/1.4.0...1.4.1)

#### What's Changed

- Fix macro hygiene by
[@&#8203;teohhanhui](https://togithub.com/teohhanhui) in
[https://github.com/uuid-rs/uuid/pull/694](https://togithub.com/uuid-rs/uuid/pull/694)
- Add #\[inline] for Uuid::from_bytes\[\_ref] and Uuid::{as,into}\_bytes
by [@&#8203;jrose-signal](https://togithub.com/jrose-signal) in
[https://github.com/uuid-rs/uuid/pull/693](https://togithub.com/uuid-rs/uuid/pull/693)
- Print uuids in examples by
[@&#8203;KodrAus](https://togithub.com/KodrAus) in
[https://github.com/uuid-rs/uuid/pull/697](https://togithub.com/uuid-rs/uuid/pull/697)
- Prepare for 1.4.1 release by
[@&#8203;KodrAus](https://togithub.com/KodrAus) in
[https://github.com/uuid-rs/uuid/pull/698](https://togithub.com/uuid-rs/uuid/pull/698)

#### New Contributors

- [@&#8203;teohhanhui](https://togithub.com/teohhanhui) made their first
contribution in
[https://github.com/uuid-rs/uuid/pull/694](https://togithub.com/uuid-rs/uuid/pull/694)
- [@&#8203;jrose-signal](https://togithub.com/jrose-signal) made their
first contribution in
[https://github.com/uuid-rs/uuid/pull/693](https://togithub.com/uuid-rs/uuid/pull/693)

**Full Changelog**:
uuid-rs/uuid@1.4.0...1.4.1

### [`v1.4.0`](https://togithub.com/uuid-rs/uuid/releases/tag/1.4.0)

[Compare
Source](https://togithub.com/uuid-rs/uuid/compare/1.3.4...1.4.0)

#### What's Changed

- Fixed wasm tests not running due to incorrect attribute target by
[@&#8203;kmusick](https://togithub.com/kmusick) in
[https://github.com/uuid-rs/uuid/pull/688](https://togithub.com/uuid-rs/uuid/pull/688)
- Fixing issue with Cloudflare Workers and wasm32-unknown-unknown when
using now() by [@&#8203;kmusick](https://togithub.com/kmusick) in
[https://github.com/uuid-rs/uuid/pull/690](https://togithub.com/uuid-rs/uuid/pull/690)
- Add `borsh` support by
[@&#8203;grovesNL](https://togithub.com/grovesNL) in
[https://github.com/uuid-rs/uuid/pull/686](https://togithub.com/uuid-rs/uuid/pull/686)
- Fix some timestamp generation by
[@&#8203;KodrAus](https://togithub.com/KodrAus) in
[https://github.com/uuid-rs/uuid/pull/691](https://togithub.com/uuid-rs/uuid/pull/691)
- Prepare for 1.4.0 release by
[@&#8203;KodrAus](https://togithub.com/KodrAus) in
[https://github.com/uuid-rs/uuid/pull/692](https://togithub.com/uuid-rs/uuid/pull/692)

#### New Contributors

- [@&#8203;kmusick](https://togithub.com/kmusick) made their first
contribution in
[https://github.com/uuid-rs/uuid/pull/688](https://togithub.com/uuid-rs/uuid/pull/688)
- [@&#8203;grovesNL](https://togithub.com/grovesNL) made their first
contribution in
[https://github.com/uuid-rs/uuid/pull/686](https://togithub.com/uuid-rs/uuid/pull/686)

**Full Changelog**:
uuid-rs/uuid@1.3.4...1.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/akrantz01/lers).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDEuMyIsInVwZGF0ZWRJblZlciI6IjM2LjguMTEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm32-unknown-unknown tests not running
2 participants