Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix links in v6 module #714

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

metalalive
Copy link
Contributor

@metalalive metalalive commented Oct 19, 2023

Fix links to struct Timestamp, trait ClockSequence, and struct Context under timestamp module.

Hello, I am new to GitHub work flow.
Is there any question / anything that needs to change again in this PR ?
Or should I first send review request to any of the maintainers of this repository ?
I don't find any contribution guide here, I don't know what else I can do,
thanks

Signed-off-by: Han Woo <metalalive2008@gmail.com>
Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @metalalive! This looks good to me 🙇

@KodrAus
Copy link
Member

KodrAus commented Nov 16, 2023

The build failure there is unrelated: some of our dependencies updated recently. I've got a fix in another PR.

@KodrAus KodrAus merged commit 90b0bc0 into uuid-rs:main Nov 16, 2023
19 of 20 checks passed
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Nov 20, 2023
Bumps uuid from 1.5.0 to 1.6.0.

Release notes
Sourced from uuid's releases.

1.6.0
What's Changed

doc: fix links in v6 module by @​metalalive in uuid-rs/uuid#714
Stabilize UUIDv6-v8 support by @​KodrAus in uuid-rs/uuid#718
Prepare for 1.6.0 release by @​KodrAus in uuid-rs/uuid#719

New Contributors

@​metalalive made their first contribution in uuid-rs/uuid#714

Full Changelog: uuid-rs/uuid@1.5.0...1.6.0



Commits

4609e61 Merge pull request #719 from uuid-rs/cargo/1.6.0
2433066 prepare for 1.6.0 release
9787ea1 Merge pull request #718 from uuid-rs/feat/stabilize-v6-plus
90b0bc0 Merge pull request #714 from metalalive/doc/fix-v6-links
1eebe7d bump msrv to 1.60.0
6bade3a just test lib with miri
3df0aaa stabilize UUIDv6-v8 support
003dc57 doc: fix links to timestamp module
See full diff in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants