feat: use native crypto.randomUUID when available #600

LinusU · 2021-11-29T15:52:39Z

Before:

uuidv4() x 2,232,325 ops/sec ±0.12% (95 runs sampled)
uuidv4() fill existing array x 8,398,262 ops/sec ±0.16% (97 runs sampled)

After:

uuidv4() x 25,076,827 ops/sec ±1.93% (96 runs sampled)
uuidv4() fill existing array x 8,407,653 ops/sec ±0.21% (97 runs sampled)

This uses the native crypto.randomUUID if available, which results in more than an 11x speedup on Node.js v16.11.1 on my M1 MacBook Air. All this while only increasing the bundle size with 34 bytes!

The patch implements my changes described here: #555 (comment)

Closes #555

broofa

One minor change, otherwise looks good. This will fit in well with the other changes planned for #598

src/v4.js

ctavan

Thank you for this patch, that’s awesome! Special thanks for covering this with a test case.

When merging, please make sure to craft a comment message that will result in a meaningful changelog entry.

LinusU · 2021-11-30T08:45:36Z

bundlewatch.config.json

-    { "path": "./examples/browser-webpack/dist/v1-size.js", "maxSize": "1.3 kB" },
-    { "path": "./examples/browser-webpack/dist/v3-size.js", "maxSize": "2.5 kB" },
-    { "path": "./examples/browser-webpack/dist/v4-size.js", "maxSize": "1.0 kB" },
-    { "path": "./examples/browser-webpack/dist/v5-size.js", "maxSize": "1.9 kB" }
+    { "path": "./examples/browser-webpack/dist/v1-size.js", "maxSize": "1.0 kB" },
+    { "path": "./examples/browser-webpack/dist/v3-size.js", "maxSize": "2.1 kB" },
+    { "path": "./examples/browser-webpack/dist/v4-size.js", "maxSize": "0.7 kB" },
+    { "path": "./examples/browser-webpack/dist/v5-size.js", "maxSize": "1.5 kB" }


Not strictly related to this PR but I noticed since I was working a lot with bundlewatch. It seems like WebPack got better with time and now matches the output size that Rollup gives us, so lowered these values to be the same for both.

LinusU · 2021-11-30T08:50:40Z

@broofa I've adressed your comment and also updated the original post to reflect the new values (same perf, even smaller bundle size!)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [uuid](https://github.com/uuidjs/uuid) | dependencies | major | [`^8.3.2` -> `^9.0.0`](https://renovatebot.com/diffs/npm/uuid/8.3.2/9.0.0) | | [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/uuid) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped)) | dependencies | major | [`^8.3.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fuuid/8.3.0/9.0.1) | --- ### Release Notes <details> <summary>uuidjs/uuid</summary> ### [`v9.0.0`](https://github.com/uuidjs/uuid/blob/HEAD/CHANGELOG.md#900-httpsgithubcomuuidjsuuidcomparev832v900-2022-09-05) [Compare Source](uuidjs/uuid@v8.3.2...v9.0.0) ##### ⚠ BREAKING CHANGES - Drop Node.js 10.x support. This library always aims at supporting one EOLed LTS release which by this time now is 12.x which has reached EOL 30 Apr 2022. - Remove the minified UMD build from the package. Minified code is hard to audit and since this is a widely used library it seems more appropriate nowadays to optimize for auditability than to ship a legacy module format that, at best, serves educational purposes nowadays. For production browser use cases, users should be using a bundler. For educational purposes, today's online sandboxes like replit.com offer convenient ways to load npm modules, so the use case for UMD through repos like UNPKG or jsDelivr has largely vanished. - Drop IE 11 and Safari 10 support. Drop support for browsers that don't correctly implement const/let and default arguments, and no longer transpile the browser build to ES2015. This also removes the fallback on msCrypto instead of the crypto API. Browser tests are run in the first supported version of each supported browser and in the latest (as of this commit) version available on Browserstack. ##### Features - optimize uuid.v1 by 1.3x uuid.v4 by 4.3x (430%) ([#597](uuidjs/uuid#597)) ([3a033f6](uuidjs/uuid@3a033f6)) - remove UMD build ([#645](uuidjs/uuid#645)) ([e948a0f](uuidjs/uuid@e948a0f)), closes [#620](uuidjs/uuid#620) - use native crypto.randomUUID when available ([#600](uuidjs/uuid#600)) ([c9e076c](uuidjs/uuid@c9e076c)) ##### Bug Fixes - add Jest/jsdom compatibility ([#642](uuidjs/uuid#642)) ([16f9c46](uuidjs/uuid@16f9c46)) - change default export to named function ([#545](uuidjs/uuid#545)) ([c57bc5a](uuidjs/uuid@c57bc5a)) - handle error when parameter is not set in v3 and v5 ([#622](uuidjs/uuid#622)) ([fcd7388](uuidjs/uuid@fcd7388)) - run npm audit fix ([#644](uuidjs/uuid#644)) ([04686f5](uuidjs/uuid@04686f5)) - upgrading from uuid3 broken link ([#568](uuidjs/uuid#568)) ([1c849da](uuidjs/uuid@1c849da)) ##### build - drop Node.js 8.x from babel transpile target ([#603](uuidjs/uuid#603)) ([aa11485](uuidjs/uuid@aa11485)) - drop support for legacy browsers (IE11, Safari 10) ([#604](uuidjs/uuid#604)) ([0f433e5](uuidjs/uuid@0f433e5)) - drop node 10.x to upgrade dev dependencies ([#653](uuidjs/uuid#653)) ([28a5712](uuidjs/uuid@28a5712)), closes [#643](uuidjs/uuid#643) ##### [8.3.2](uuidjs/uuid@v8.3.1...v8.3.2) (2020-12-08) ##### Bug Fixes - lazy load getRandomValues ([#537](uuidjs/uuid#537)) ([16c8f6d](uuidjs/uuid@16c8f6d)), closes [#536](uuidjs/uuid#536) ##### [8.3.1](uuidjs/uuid@v8.3.0...v8.3.1) (2020-10-04) ##### Bug Fixes - support expo>=39.0.0 ([#515](uuidjs/uuid#515)) ([c65a0f3](uuidjs/uuid@c65a0f3)), closes [#375](uuidjs/uuid#375) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Renovate Bot <renovate@vylpes.com> Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/Droplet/pulls/111 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: RenovateBot <renovate@vylpes.com> Co-committed-by: RenovateBot <renovate@vylpes.com>

feat: use native crypto.randomUUID when available

5d127ea

LinusU requested a review from broofa November 29, 2021 15:52

LinusU mentioned this pull request Nov 29, 2021

feat: use Node.js v15.6 crypto.randomUUID() functions if it's avail… #555

Closed

broofa requested changes Nov 29, 2021

View reviewed changes

src/v4.js Outdated Show resolved Hide resolved

ctavan approved these changes Nov 29, 2021

View reviewed changes

LinusU added 2 commits November 30, 2021 09:42

fix: tweak options checking in v4

282774a

fix: tweak webpack bundlewatch config

e447adf

LinusU commented Nov 30, 2021

View reviewed changes

LinusU requested a review from broofa November 30, 2021 08:51

Merge branch 'main' into lu-native

8292d92

broofa approved these changes Dec 1, 2021

View reviewed changes

LinusU merged commit c9e076c into main Dec 2, 2021

LinusU deleted the lu-native branch December 2, 2021 09:04

This was referenced Dec 2, 2021

Secure Contexts #602

Closed

Support native randomUUID() #554

Closed

yosiat mentioned this pull request Nov 7, 2022

remove p-defer and use crypto.randomUUID if available bringg/node-arnavmq#38

Closed

jimniels mentioned this pull request Apr 25, 2023

refactor: swap out uuid lib for native randomUUID quadratichq/quadratic#441

Closed

broofa mentioned this pull request Oct 11, 2023

perf: remove superfluous call to toLowerCase #677

Merged

matus-tomlein mentioned this pull request Oct 18, 2024

Update uuid package dependency to version 10.0.0 (close #1305) snowplow/snowplow-javascript-tracker#1357

Merged

This was referenced Oct 27, 2024

chore(main): release 11.0.0 #808

Merged

chore(main): release 11.0.0 #809

Merged

chore(main): release 11.0.0 #810

Closed

chore(main): release 11.0.0 #813

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use native crypto.randomUUID when available #600

feat: use native crypto.randomUUID when available #600

LinusU commented Nov 29, 2021 •

edited

Loading

broofa left a comment

ctavan left a comment

LinusU Nov 30, 2021

ctavan Nov 30, 2021

LinusU commented Nov 30, 2021

feat: use native crypto.randomUUID when available #600

feat: use native crypto.randomUUID when available #600

Conversation

LinusU commented Nov 29, 2021 • edited Loading

broofa left a comment

Choose a reason for hiding this comment

ctavan left a comment

Choose a reason for hiding this comment

LinusU Nov 30, 2021

Choose a reason for hiding this comment

ctavan Nov 30, 2021

Choose a reason for hiding this comment

LinusU commented Nov 30, 2021

LinusU commented Nov 29, 2021 •

edited

Loading