dd: move unit tests into dd.rs and test_dd.rs #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
commented
Feb 15, 2022
Comment on lines
+813
to
+823
| // TODO I think uppercase and lowercase are unintentionally swapped in | ||
| // the code that parses the command-line arguments. See this line from | ||
| // `parseargs.rs`: | ||
| // | ||
| // (ConvFlag::FmtAtoI, ConvFlag::UCase) => Some(&ASCII_TO_IBM_UCASE_TO_LCASE), | ||
| // (ConvFlag::FmtAtoI, ConvFlag::LCase) => Some(&ASCII_TO_IBM_LCASE_TO_UCASE), | ||
| // | ||
| // If my reading is correct and that is a typo, then the | ||
| // UCASE_TO_LCASE and LCASE_TO_UCASE in those lines should be swapped, | ||
| // and the expected output for the following two tests should be | ||
| // updated accordingly. |
There was a problem hiding this comment.
I think there is a bug in the code, but I didn't fix it in this pull request.
Add helper method `CmdResult::stdout_is_fixture_bytes()`, which is like `stdout_is_fixture()` but compares stdout to the raw bytes of a given file instead of decoding the contents of the file to a UTF-8 string.
Clean up unit tests in the `dd` crate to make them easier to manage. This commit does a few things. * move test cases that test the complete functionality of the `dd` program from the `dd_unit_tests` module up to the `tests/by-util/test_dd.rs` module so that they can take advantage of the testing framework and common testing tools provided by uutils, * move test cases that test internal functions of the `dd` implementation into the `tests` module within `dd.rs` so that they live closer to the code they are testing, * replace test cases defined by macros with test cases defined by plain old functions to make the test cases easier to read at a glance.
|
This is great, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up unit tests in the
ddcrate to make them easier tomanage. This commit does a few things.
ddprogram from the
dd_unit_testsmodule up to thetests/by-util/test_dd.rsmodule so that they can take advantage ofthe testing framework and common testing tools provided by uutils,
ddimplementation into the
testsmodule withindd.rsso that theylive closer to the code they are testing,
plain old functions to make the test cases easier to read at a
glance.