Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: change termsize dependency to terminal_size #3864

Merged

Conversation

niyaznigmatullin
Copy link
Contributor

  • termsize had no releases since 2017 and it uses old dependencies
  • terminal_size is used by clap, so we depend from it anyway
  • Removed termsize dependency and added terminal_size dependency
  • termsize was only used in a single place
  • This removed several other dependencies as well

@tertsdiepraam
Copy link
Member

Kind of unrelated to this change, but it's pretty cool that terminal_size uses rustix and windows-sys instead of libc and winapi. Too bad this one doesn't support setting the terminal size. I decided to go with raw ioctl calls via nix for stty because we eventually need to set the size there too. I kinda wish one of these libraries would implement that in a cross-platform way.

@niyaznigmatullin
Copy link
Contributor Author

Talking about that, I’ve made the dependency version 0.1 as it's used in clap version 3, and 0.1 uses winapi and libc. I thought we could bump it, when clap does it.

@niyaznigmatullin niyaznigmatullin force-pushed the migrate_termsize_to_terminal_size branch from 18351cc to db9f724 Compare August 22, 2022 15:53
@sylvestre
Copy link
Contributor

Well done for finding this issue

@sylvestre sylvestre merged commit 5a726e1 into uutils:main Aug 23, 2022
@niyaznigmatullin niyaznigmatullin deleted the migrate_termsize_to_terminal_size branch August 23, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants