Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to bring cksum up to date with hashsum #5122

Closed
wants to merge 6 commits into from

Conversation

tertsdiepraam
Copy link
Member

For context see: #4414

cksum is lagging behind hashsum and needs to be updated. One way to do with would be to share functions between the two, but I didn't want to do that, because I do not like many aspects of the current hashsum implementation. So instead I want cksum to be the base of all the cksum-like utilities. But because that's a lot of work I'll take some slow steps first.

It's a draft because I need to add some tests.

@sylvestre
Copy link
Contributor

@tertsdiepraam is it ready ?

This was referenced Dec 25, 2023
@uutils uutils deleted a comment from github-actions bot Dec 25, 2023
@sylvestre
Copy link
Contributor

a few clippy warnings:

error: constants have by default a `'static` lifetime
  --> src/uu/cksum/src/cksum.rs:54:24
   |
54 |     pub const BINARY: &'static str = "binary";
   |                       -^^^^^^^---- help: consider removing `'static`: `&str`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
   = note: `-D clippy::redundant-static-lifetimes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::redundant_static_lifetimes)]`

@sylvestre
Copy link
Contributor

no activity for a while, closing

@sylvestre sylvestre closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants