ls: upgrade uutils-term-grid to 0.5
#5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
force-pushed
the
ls-new-term-grid
branch
from
b798538 to
a58c444
Compare
tertsdiepraam
changed the title
ls: upgrade uutils-term-grid to 0.5
tertsdiepraam
force-pushed
the
ls-new-term-grid
branch
from
a58c444 to
2036d33
Compare
|
@tertsdiepraam any plan here ? :) |
tertsdiepraam
force-pushed
the
ls-new-term-grid
branch
2 times, most recently
from
c84f7ed to
e77d548
Compare
tertsdiepraam
force-pushed
the
ls-new-term-grid
branch
from
e77d548 to
e13ba99
Compare
|
GNU testsuite comparison: |
src/uu/ls/Cargo.toml
Outdated
Comment on lines
17
to
19
| [dependencies] | ||
| ansi-width = "0.1.0" | ||
| clap = { workspace = true, features = ["env"] } |
There was a problem hiding this comment.
The fact that every entry except this one says workspace = true and doesn't provide a specific version number makes me wonder why it's the other way around here.
sylvestre
reviewed
May 1, 2024
|
GNU testsuite comparison: |
|
Ah I was just gonna do that. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for now, because we need to release a new version of term-grid first, but I wanted to show how the new API changes in uutils/uutils-term-grid#27 are affecting
ls.