-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More implement argument pattern #5966
More implement argument pattern #5966
Conversation
Some checks are failing with the message "error: the compiler unexpectedly panicked. this is a bug." However, I am unable to reproduce this bug Edit: I updated my Rust toolchain and now I get the error when running Should I open an issue on the Rust lang repository? |
If there are no issues for it already, that would be great, especially if you can figure which crate triggers the ICE. |
I guess it is the following issue: rust-lang/rust#120909 |
Sorry, I forgot I had it in Drafts. I believe it's ready for review. The compilation issue was also resolved by reverting the commit that introduced the problem: rust-lang/rust#121167 |
24b2d3e
to
a227af7
Compare
I forgot what we already discussed 6 months ago so I might be rehashing stuff, but I can't find this feature in util-linux |
Yes, this implements the Therefore, I used what was given in #2320 |
Ah it's my fault then 😄 I think this is a good idea for now. It's nice to at least have the functionality. |
Thanks for your PR :) |
This implements the Pattern option to
more
.I put this as a draft for now, because the implementation is not as the one from gnu more. The implementation was discussed on the discord server, but it has been 6 months since then I don't know if anything has changed.
Currently
more
does this:Before displaying each file,
more
searches for the pattern. If the pattern is not found, it displays the message "Pattern not found." Otherwise, it displays the file starting from the pattern match.