-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shuf: treat -e as a flag, not as a multi-value arg #5989
Merged
tertsdiepraam
merged 1 commit into
uutils:main
from
BenWiederhake:dev-shuf-echo-anywhere
Feb 22, 2024
Merged
shuf: treat -e as a flag, not as a multi-value arg #5989
tertsdiepraam
merged 1 commit into
uutils:main
from
BenWiederhake:dev-shuf-echo-anywhere
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
BenWiederhake
force-pushed
the
dev-shuf-echo-anywhere
branch
from
February 21, 2024 21:09
b8f7710
to
c4a0543
Compare
Changes since last push:
|
BenWiederhake
force-pushed
the
dev-shuf-echo-anywhere
branch
from
February 21, 2024 21:36
c4a0543
to
69a48c8
Compare
Changes since last push:
|
cakebaker
reviewed
Feb 22, 2024
BenWiederhake
force-pushed
the
dev-shuf-echo-anywhere
branch
from
February 22, 2024 22:22
69a48c8
to
a59924e
Compare
Changes since last push:
|
Both failures seem to be flakes:
|
Thanks! Your updates on the force pushes are great by the way. Really useful while reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements and tests support for the weird permitted argument order of
shuf
, especially for invocations likeshuf -ez firstarg secondarg
, where thez
shall not be interpreted as a value to-e
.This moves us closer to passing the GNU testsuite.
Related:
uutils-arg
).This PR sadly slightly degrades the quality of the error message in one case:
Before:
After:
Note that this does not affect the
--help
message, so I think it's good enough.