Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android CI: workaround: run builds with retry #5993

Merged

Conversation

cre4ture
Copy link
Contributor

@cre4ture cre4ture commented Feb 20, 2024

tries to address #5992
UDPATE: It really helps. See comments.

@cre4ture cre4ture force-pushed the fix/workaround_for_textfile_busy_error branch 2 times, most recently from ef0de0d to 1daf36b Compare February 24, 2024 13:19
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre force-pushed the fix/workaround_for_textfile_busy_error branch from 1daf36b to 36359f2 Compare February 25, 2024 08:52
@cre4ture cre4ture force-pushed the fix/workaround_for_textfile_busy_error branch from 36359f2 to 263a163 Compare February 25, 2024 18:09
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cre4ture cre4ture marked this pull request as ready for review February 26, 2024 21:48
@cre4ture
Copy link
Contributor Author

cre4ture commented Feb 26, 2024

I finally reproduced the issue once on this branch. See attached logs below.
This proves that the issue is really some race-condition like temporary issue,
where a retry helps to finish building process successfully.

There I recommend to bring this workaround to main branch.

2024-02-25T18:23:00.8438134Z [2024-02-25 18:23:00] address sizes	: 40 bits physical, 48 bits virtual
2024-02-25T18:23:00.8451464Z [2024-02-25 18:23:00] power management:
2024-02-25T18:23:00.8464611Z [2024-02-25 18:23:00] 
2024-02-25T18:23:00.8482502Z Try #1 of 3: run run_command_via_ssh export CARGO_TERM_COLOR=always;
2024-02-25T18:23:00.8483576Z              export CARGO_INCREMENTAL=0;              cd ~/coreutils && cargo build --features feat_os_unix_android
2024-02-25T18:23:01.1457255Z [2024-02-25 18:23:01] �[1m�[32m    Updating�[0m crates.io index
2024-02-25T18:23:02.0445025Z [2024-02-25 18:23:02] �[1m�[32m Downloading�[0m crates ...
2024-02-25T18:23:02.5256421Z [2024-02-25 18:23:02] �[1m�[32m  Downloaded�[0m keccak v0.1.4
2024-02-25T18:23:02.5449584Z [2024-02-25 18:23:02] �[1m�[32m  Downloaded�[0m libm v0.2.7
2024-02-25T18:23:02.5684589Z [2024-02-25 18:23:02] �[1m�[32m  Downloaded�[0m onig v6.4.0
2024-02-25T18:23:02.5883226Z [2024-02-25 18:23:02] �[1m�[32m  Downloaded�[0m siphasher v0.3.10
2024-02-25T18:23:02.6035124Z [2024-02-25 18:23:02] �[1m�[32m  Downloaded�[0m getrandom v0.2.9
2024-02-25T18:23:02.6213993Z [2024-02-25 18:23:02] �[1m�[32m  Downloaded�[0m rustix v0.37.26
2024-02-25T18:23:02.6632596Z [2024-02-25 18:23:02] �[1m�[32m  Downloaded�[0m quick-error v2.

....


2024-02-25T18:23:38.6913188Z [2024-02-25 18:23:38] �[1m�[32m   Compiling�[0m smallvec v1.13.1
2024-02-25T18:23:39.0193541Z [2024-02-25 18:23:39] �[1m�[32m   Compiling�[0m pkg-config v0.3.26
2024-02-25T18:23:39.5033086Z [2024-02-25 18:23:39] �[1m�[32m   Compiling�[0m portable-atomic v0.3.15
2024-02-25T18:23:39.5874492Z [2024-02-25 18:23:39] �[1m�[32m   Compiling�[0m parking_lot_core v0.9.9
2024-02-25T18:23:40.1572933Z [2024-02-25 18:23:40] �[1m�[31merror�[0m�[1m:�[0m failed to run custom build command for `portable-atomic v0.3.15`
2024-02-25T18:23:40.1593065Z [2024-02-25 18:23:40] 
2024-02-25T18:23:40.1614762Z [2024-02-25 18:23:40] Caused by:
2024-02-25T18:23:40.1636787Z [2024-02-25 18:23:40]   could not execute process `/data/data/com.termux/files/home/coreutils/target/debug/build/portable-atomic-10228312d9d1b245/build-script-build` (never executed)
2024-02-25T18:23:40.1658723Z [2024-02-25 18:23:40] 
2024-02-25T18:23:40.1679356Z [2024-02-25 18:23:40] Caused by:
2024-02-25T18:23:40.1701175Z [2024-02-25 18:23:40]   Text file busy (os error 26)
2024-02-25T18:23:40.1719787Z [2024-02-25 18:23:40] �[1m�[33mwarning�[0m�[1m:�[0m build failed, waiting for other jobs to finish...
2024-02-25T18:23:43.3223197Z Try #2 of 3: run run_command_via_ssh export CARGO_TERM_COLOR=always;
2024-02-25T18:23:43.3225069Z              export CARGO_INCREMENTAL=0;              cd ~/coreutils && cargo build --features feat_os_unix_android
2024-02-25T18:23:43.9077434Z [2024-02-25 18:23:43] �[1m�[32m   Compiling�[0m parking_lot_core v0.9.9
2024-02-25T18:23:43.9095840Z [2024-02-25 18:23:43] �[1m�[32m   Compiling�[0m hostname v0.3.1
2024-02-25T18:23:43.9113535Z [2024-02-25 18:23:43] �[1m�[32m   Compiling�[0m portable-atomic v0.3.15
2024-02-25T18:23:43.9129043Z [2024-02-25 18:23:43] �[1m�[32m   Compiling�[0m onig_sys v69.8.1
2024-02-25T18:23:43.9229406Z [2024-02-25 18:23:43] �[1m�[32m   Compiling�[0m signal-hook v0.3.17
2024-02-25T18:23:43.9828666Z [2024-02-25 18:23:43] �[1m�[32m   Compiling�[0m num-bigint v0.4


......


2024-02-25T18:24:19.8553173Z [2024-02-25 18:24:19] �[1m�[32m   Compiling�[0m uu_chown v0.0.24 (/data/data/com.termux/files/home/coreutils/src/uu/chown)
2024-02-25T18:24:20.2022202Z [2024-02-25 18:24:20] �[1m�[32m   Compiling�[0m uu_fold v0.0.24 (/data/data/com.termux/files/home/coreutils/src/uu/fold)
2024-02-25T18:24:20.3630108Z [2024-02-25 18:24:20] �[1m�[32m   Compiling�[0m uu_dirname v0.0.24 (/data/data/com.termux/files/home/coreutils/src/uu/dirname)
2024-02-25T18:24:20.4919110Z [2024-02-25 18:24:20] �[1m�[32m   Compiling�[0m uu_groups v0.0.24 (/data/data/com.termux/files/home/coreutils/src/uu/groups)
2024-02-25T18:24:20.5394735Z [2024-02-25 18:24:20] �[1m�[32m   Compiling�[0m uu_unexpand v0.0.24 (/data/data/com.termux/files/home/coreutils/src/uu/unexpand)
2024-02-25T18:24:20.6688802Z [2024-02-25 18:24:20] �[1m�[32m   Compiling�[0m clap_complete v4.4.0
2024-02-25T18:24:31.0318417Z [2024-02-25 18:24:31] �[1m�[32m    Finished�[0m dev [unoptimized + debuginfo] target(s) in 47.48s
2024-02-25T18:24:31.0457006Z Done in try#2
2024-02-25T18:24:31.0457803Z Finished build
2024-02-25T18:24:31.0590495Z [command]/usr/bin/sh -c util/android-commands.sh tests
2024-02-25T18:24:31.1094281Z next round robin repo_url: 1
2024-02-25T18:24:31.1095263Z ====== runner information ======

Logs are from here:
https://github.com/cre4ture/coreutils/actions/runs/8039856982/job/21957302175

@cre4ture
Copy link
Contributor Author

@cakebaker, @tertsdiepraam, @sylvestre - please review

@sylvestre
Copy link
Contributor

excellent, thanks :)

@sylvestre sylvestre merged commit 372cd52 into uutils:main Feb 28, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants