-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cp: fix flaky test test_cp_arg_interactive_update, document adjacent bug #6020
Merged
cakebaker
merged 1 commit into
uutils:main
from
BenWiederhake:dev-cp-flaky-arg_interactive_update
Mar 1, 2024
Merged
cp: fix flaky test test_cp_arg_interactive_update, document adjacent bug #6020
cakebaker
merged 1 commit into
uutils:main
from
BenWiederhake:dev-cp-flaky-arg_interactive_update
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWiederhake
force-pushed
the
dev-cp-flaky-arg_interactive_update
branch
from
February 25, 2024 19:44
689c563
to
0ed13f3
Compare
Changes since last push:
|
The CI failures are both flakes:
The most-relevant output of the macos aarch64 failure
|
GNU testsuite comparison:
|
sylvestre
force-pushed
the
dev-cp-flaky-arg_interactive_update
branch
from
February 28, 2024 08:42
0ed13f3
to
97da29b
Compare
GNU testsuite comparison:
|
cakebaker
reviewed
Mar 1, 2024
BenWiederhake
force-pushed
the
dev-cp-flaky-arg_interactive_update
branch
from
March 1, 2024 10:41
97da29b
to
ba1c6b0
Compare
Changes since last push:
|
|
Thanks! |
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4725
This fixes a flaky test that causes real problems.
As the test already documents,
-u -i
won't show a prompt, so trying to pipe some stdin into it is pointless, and also causes a race.