Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/flaky timeout kill subprocess #6061

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Fix/flaky timeout kill subprocess #6061

merged 4 commits into from
Mar 13, 2024

Conversation

cre4ture
Copy link
Contributor

Addresses #5459

Stability improved by:

  • sending only one signal
  • waiting for child to stop
  • adapt test such that the immediate child is the one to wait for

@sylvestre
Copy link
Contributor

Well done :)

@sylvestre sylvestre merged commit f89cfe2 into uutils:main Mar 13, 2024
62 checks passed
@cre4ture cre4ture deleted the fix/flaky_timeout_kill_subprocess branch March 13, 2024 12:09
@cakebaker cakebaker mentioned this pull request Mar 13, 2024
Closed
@chenrui333 chenrui333 mentioned this pull request Mar 24, 2024
Merged
@moonfruit moonfruit mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cre4ture @sylvestre