dd fix gnu test not-rewound.sh
#6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre4ture
force-pushed
the
fix/gnu_test_dd_not_rewound_sh
branch
from
6c0ff65 to
3137bd3
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cre4ture
force-pushed
the
fix/gnu_test_dd_not_rewound_sh
branch
from
9d2578d to
3c6079f
Compare
|
GNU testsuite comparison: |
|
would it be possible to replicate this test on our side? thanks |
cre4ture
changed the title
dd fix gnu test not-rewound.sh
|
GNU testsuite comparison: |
cre4ture
force-pushed
the
fix/gnu_test_dd_not_rewound_sh
branch
from
563226a to
3de43ad
Compare
|
@sylvestre test added. ready for review. :-) |
|
GNU testsuite comparison: |
sylvestre
reviewed
Mar 17, 2024
| @@ -0,0 +1,83 @@ | |||
| // This file is part of the uutils coreutils package. | |||
There was a problem hiding this comment.
could you please document it?
As it will be part of the API like:
https://docs.rs/uucore/0.0.24/uucore/error/index.html
There was a problem hiding this comment.
thats cool.
I added some documentation.
Thanks.
this is important as the fd holds the file offset we need to use
cre4ture
force-pushed
the
fix/gnu_test_dd_not_rewound_sh
branch
from
3de43ad to
4057717
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.