lint: fix lints of new Rust version

src/uu/dd/src/parseargs/unit_tests.rs

@@ -13,6 +13,7 @@ use crate::parseargs::Parser;
 use crate::StatusLevel;
 
 #[cfg(not(any(target_os = "linux", target_os = "android")))]
+#[allow(clippy::useless_vec)]
 #[test]
 fn unimplemented_flags_should_error_non_linux() {
     let mut succeeded = Vec::new();
@@ -55,6 +56,7 @@ fn unimplemented_flags_should_error_non_linux() {
 }
 
 #[test]
+#[allow(clippy::useless_vec)]
 fn unimplemented_flags_should_error() {
     let mut succeeded = Vec::new();
 

src/uu/sort/src/sort.rs

@@ -254,6 +254,7 @@ impl Output {
             let file = OpenOptions::new()
                 .write(true)
                 .create(true)
+                .truncate(true)
                 .open(name)
                 .map_err(|e| SortError::OpenFailed {
                     path: name.to_owned(),

src/uucore/src/lib/features/perms.rs

@@ -660,10 +660,11 @@ mod tests {
         assert_eq!(path.to_str(), Some(""));
         // The main point to test here is that we don't crash.
         // The result should be 'false', to avoid unnecessary and confusing warnings.
-        assert_eq!(false, is_root(&path, false));
-        assert_eq!(false, is_root(&path, true));
+        assert!(!is_root(&path, false));
+        assert!(!is_root(&path, true));
     }
 
+    #[allow(clippy::needless_borrow)]
     #[cfg(unix)]
     #[test]
     fn test_literal_root() {
@@ -675,16 +676,16 @@ mod tests {
             "cfg(unix) but using non-unix path delimiters?!"
         );
         // Must return true, this is the main scenario that --preserve-root shall prevent.
-        assert_eq!(true, is_root(&path, false));
-        assert_eq!(true, is_root(&path, true));
+        assert!(is_root(&path, false));
+        assert!(is_root(&path, true));
     }
 
     #[cfg(unix)]
     #[test]
     fn test_symlink_slash() {
         let temp_dir = tempdir().unwrap();
         let symlink_path = temp_dir.path().join("symlink");
-        unix::fs::symlink(&PathBuf::from("/"), &symlink_path).unwrap();
+        unix::fs::symlink(PathBuf::from("/"), symlink_path).unwrap();
         let symlink_path_slash = temp_dir.path().join("symlink/");
         // Must return true, we're about to "accidentally" recurse on "/",
         // since "symlink/" always counts as an already-entered directory
@@ -697,8 +698,8 @@ mod tests {
         //   chown: it is dangerous to operate recursively on 'slink-to-root/' (same as '/')
         //   chown: use --no-preserve-root to override this failsafe
         //   [$? = 1]
-        assert_eq!(true, is_root(&symlink_path_slash, false));
-        assert_eq!(true, is_root(&symlink_path_slash, true));
+        assert!(is_root(&symlink_path_slash, false));
+        assert!(is_root(&symlink_path_slash, true));
     }
 
     #[cfg(unix)]
@@ -707,9 +708,9 @@ mod tests {
         // This covers both the commandline-argument case and the recursion case.
         let temp_dir = tempdir().unwrap();
         let symlink_path = temp_dir.path().join("symlink");
-        unix::fs::symlink(&PathBuf::from("/"), &symlink_path).unwrap();
+        unix::fs::symlink(PathBuf::from("/"), &symlink_path).unwrap();
         // Only return true  we're about to "accidentally" recurse on "/".
-        assert_eq!(false, is_root(&symlink_path, false));
-        assert_eq!(true, is_root(&symlink_path, true));
+        assert!(!is_root(&symlink_path, false));
+        assert!(is_root(&symlink_path, true));
     }
 }

src/uucore/src/lib/parser/parse_glob.rs

@@ -97,7 +97,7 @@ mod tests {
 
         // test that we don't look for closing square brackets unnecessarily
         // Verifies issue #5584
-        let chars = std::iter::repeat("^[").take(174571).collect::<String>();
+        let chars = "^[".repeat(174571);
         assert_eq!(fix_negation(chars.as_str()), chars);
     }
 

tests/by-util/test_cksum.rs

@@ -397,7 +397,7 @@ fn test_base64_multiple_files() {
         .arg("alice_in_wonderland.txt")
         .succeeds()
         .no_stderr()
-        .stdout_is_fixture_bytes(format!("base64/md5_multiple_files.expected"));
+        .stdout_is_fixture_bytes("base64/md5_multiple_files.expected");
 }
 
 #[test]