Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config terminal simulation for specific stdios only #6125

Merged
merged 1 commit into from
May 1, 2024

Conversation

cre4ture
Copy link
Contributor

as discussed in PR #6121, it makes sense for tests to have more fine granular control over the terminal simulation.
This PR improves this.

@sylvestre sylvestre force-pushed the feature/config_terminal_simulation branch from 1b2dd29 to 807ae04 Compare March 30, 2024 21:51
@cre4ture cre4ture force-pushed the feature/config_terminal_simulation branch from 807ae04 to 684e1f9 Compare April 1, 2024 12:39
@cre4ture cre4ture force-pushed the feature/config_terminal_simulation branch from 684e1f9 to 08900b0 Compare April 6, 2024 21:39
Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo.

I must admit that I don't quite understand yet how this fixes the problem in #6121, but if @tertsdiepraam says so, then I'm sure it makes sense.

tests/common/util.rs Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 6, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)

@cre4ture cre4ture force-pushed the feature/config_terminal_simulation branch from 08900b0 to 4bcd8cc Compare April 6, 2024 23:28
@cre4ture cre4ture requested a review from BenWiederhake April 6, 2024 23:33
Copy link

github-actions bot commented Apr 7, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/env/env is no longer failing!

Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for handling the typo!

Since I don't understand the context of this PR, I don't want to be the person who clicks "merge". I suggest @tertsdiepraam instead. :)

@cre4ture cre4ture force-pushed the feature/config_terminal_simulation branch 3 times, most recently from 22f3b37 to e86dfdd Compare April 7, 2024 09:23
Copy link

github-actions bot commented Apr 7, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cre4ture cre4ture force-pushed the feature/config_terminal_simulation branch from e86dfdd to 537941b Compare April 23, 2024 17:56
@cre4ture
Copy link
Contributor Author

cre4ture commented May 1, 2024

@tertsdiepraam @BenWiederhake please review + merge if fine

@sylvestre sylvestre merged commit b28b79d into uutils:main May 1, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants