Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cksum: adding -b as the short form of --base64 #6187

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jadijadi
Copy link
Contributor

@jadijadi jadijadi commented Apr 4, 2024

The base64 coding was present & only lacked the short option form (-b). Added.

closes #5706

@sylvestre
Copy link
Contributor

could you please add a test to make sure we don't regress? thanks

@jadijadi jadijadi force-pushed the cksum-base64-short-option branch from 958d882 to 4312f3c Compare April 4, 2024 11:39
@jadijadi
Copy link
Contributor Author

jadijadi commented Apr 4, 2024

could you please add a test to make sure we don't regress? thanks

Sure. There were already tests for base64 and I added a loop to check both with -b and --base64

@cakebaker cakebaker merged commit 082528d into uutils:main Apr 4, 2024
64 checks passed
@cakebaker
Copy link
Contributor

Good catch, thanks!

@Rudxain
Copy link

Rudxain commented Apr 27, 2024

Doesn't this "collide" with --brief? I mean, it doesn't collide with this specific program, but it seems inconsistent with others.

I'm confused. According to GNU's md5sum --help, -b is --binary...?

@cakebaker
Copy link
Contributor

Yes, you are right, -b is no longer a shortcut of --base64, it was changed in GNU 9.4. My mistake, I didn't caught it during the review :| I will open a ticket for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement cksum -b
4 participants