-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): add CICD job build_programs_individually #6212
Conversation
GNU testsuite comparison:
|
My idea was to base it on the show-utils script, which we do elsewhere in the CI too. This seems to work, but only for linux. Nevertheless, this would be great to have! We could also try building the packages instead of the multicall binary. 🤔 Other considerations:
|
@gierens any opinion ? :) |
Sure :) ... sorry for the late reply, the new semester just started and I got a little distracted :D
Oh neat, that's a lot smarter of course :) ... yeah the CICD workflow is a little intense and I just skimmed it, but I could've probably checked the util folder, my bad :D
I guess with the show-utils batch file it would be possible to make it work on windows, too.
Sounds reasonable.
Hm, I guess we could first check how long that would actually run with building and tests, and then decide. Also in case it really takes too long, it could maybe be parallelized to some extent. It's getting a little late here, but I can take a look at it tomorrow :) |
2e6eda7
to
0d6f193
Compare
@tertsdiepraam @sylvestre alright, I revised the CI job: It uses
In the run I executed just now in my fork it took roughly 1min@ubuntu, 2min@macos and 4min@windows, so not should be fine I guess. |
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks! Just one question.
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
0d6f193
to
8d4763b
Compare
GNU testsuite comparison:
|
Thanks for your PR :) |
This adds a rudimentary CI job for building the different programs individually by basically looping over a subset of the
cargo feature
output.Would look like this: https://github.com/gierens/coreutils/actions/runs/8638198438/job/23682121436
Not sure if this is what you're looking for or rather some static list, I just stumbled across this issue and did something similar before. A future alternative could be cargo-all-features (https://github.com/frewsxcv/cargo-all-features) but unfortunately this is more for feature combinations and still lacks a few features thus would require a fork at the moment.
Resolves: #6097