mv: Fix bug on Redox OS introduced by xattr handling #6215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
|
Thank you! Can I nudge you to add a CI script so that we automatically build and test on redox? If I understand you correctly, this would have been caught by the automated tests, right? :) |
|
@BenWiederhake it's already in the CI, though the tests are skipped, see #5642 |
|
Thanks! Yeah, I'll have a look at the outstanding issues for getting CI tests running. We all want to move that way. :) |
|
Ah, fantastic! Yeah, I should have checked that instead of just assuming. Is it perhaps possible to enable the tests gradually? This way we don't have any major regressions while you're working towards the goal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redox OS doesn't support extended attributes yet, so this commit breaks
mvthere for the "fallback" case ofrename_with_fallback().This PR addresses the issue through a few simple
cfgconditional changes. Tested manually on Linux and Redox.