Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashsum: implement the ignore-missing option #6230

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

sylvestre
Copy link
Contributor

Tested by gnu/tests/cksum/md5sum.pl

Tested by gnu/tests/cksum/md5sum.pl
Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is straight-forward, and the test checks the implementation. But I think this case was missed?

$ ../gnu/src/md5sum --ignore-missing LICENSE 
../gnu/src/md5sum: the --ignore-missing option is meaningful only when verifying checksums
Try '../gnu/src/md5sum --help' for more information.
[$? = 1]
$ cargo run md5sum --ignore-missing LICENSE 
e74349878141b240070458d414ab3b64  LICENSE
$

src/uu/hashsum/src/hashsum.rs Outdated Show resolved Hide resolved
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

@sylvestre sylvestre requested a review from BenWiederhake April 16, 2024 09:11
Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sylvestre sylvestre merged commit 4e1dbcd into uutils:main Apr 17, 2024
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants