Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinky: use UTC if offset can't be determined #6414

Merged
merged 1 commit into from
May 19, 2024

Conversation

cakebaker
Copy link
Contributor

This PR fixes the same issue as #6413 but in a different place. It should fix the remaining pinky tests in the failing Build (macos-latest, x86_64-apple-darwin, feat_os_macos) job in the CI.

@@ -115,7 +115,7 @@ struct Pinky {

fn idle_string(when: i64) -> String {
thread_local! {
static NOW: time::OffsetDateTime = time::OffsetDateTime::now_local().unwrap();
static NOW: time::OffsetDateTime = time::OffsetDateTime::now_local().unwrap_or_else(|_| time::OffsetDateTime::now_utc());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the coverage isn't happy, i guess there is nothing we can do

@sylvestre sylvestre merged commit f013d23 into uutils:main May 19, 2024
66 of 68 checks passed
@cakebaker cakebaker deleted the pinky_fix_idle_string branch May 20, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants