matchers: Replace new_box() with an into_box() trait method #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 52.86% 52.87% +0.01%
==========================================
Files 24 24
Lines 4754 4709 -45
Branches 1550 1535 -15
==========================================
- Hits 2513 2490 -23
Misses 1684 1684
+ Partials 557 535 -22
Continue to review full report at Codecov.
|
|
could you please explain in the commit message the why ? |
This lets us get rid of the boilerplate new_box() inherent method on most Matcher impls. It also removes the need for explicit boxing before passing Matchers to a few functions like new_and_matcher().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.