Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find/matchers: Implement -mount as an alias for -xdev #165

Merged
merged 2 commits into from
Jun 1, 2022
Merged

find/matchers: Implement -mount as an alias for -xdev #165

merged 2 commits into from
Jun 1, 2022

Conversation

tavianator
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #165 (1bfbe76) into main (e04cd34) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   48.98%   49.10%   +0.11%     
==========================================
  Files          28       28              
  Lines        4795     4802       +7     
  Branches     1271     1272       +1     
==========================================
+ Hits         2349     2358       +9     
+ Misses       1816     1806      -10     
- Partials      630      638       +8     
Impacted Files Coverage Δ
src/find/matchers/mod.rs 64.51% <100.00%> (+1.07%) ⬆️
tests/find_cmd_tests.rs 84.47% <100.00%> (+0.70%) ⬆️
src/xargs/mod.rs 78.29% <0.00%> (-1.56%) ⬇️
src/lib.rs 28.59% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04cd34...1bfbe76. Read the comment docs.

@sylvestre
Copy link
Sponsor Contributor

would it be possible to add a test?

@tavianator
Copy link
Contributor Author

Hmm, there's no existing test for -xdev and writing a good one requires actually mounting something. I could add a test that at least ensures that -mount/-xdev don't change the results on test_data.

@sylvestre sylvestre merged commit 37547b0 into uutils:main Jun 1, 2022
@sylvestre
Copy link
Sponsor Contributor

and improves the code coverage, cool :)

@tavianator tavianator deleted the mount branch June 1, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants