Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find: make InodeMatcher & LinksMatcher unix-only #393

Conversation

cakebaker
Copy link
Contributor

@cakebaker cakebaker commented May 29, 2024

This PR is a refactoring that makes the implementations of InodeMatcher and LinksMatcher unix-only. And moves the error handling for other platforms to where we handle -inum and -links.

The refactoring is done to get rid of two "field x is never read" warnings on Windows (see, for example, https://github.com/uutils/findutils/actions/runs/9271426702/job/25506758917#step:6:185)

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.51%. Comparing base (5b19ea2) to head (cd0e119).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   60.48%   60.51%   +0.02%     
==========================================
  Files          32       32              
  Lines        4069     4067       -2     
  Branches      895      893       -2     
==========================================
  Hits         2461     2461              
  Misses       1254     1254              
+ Partials      354      352       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cakebaker cakebaker marked this pull request as draft May 29, 2024 08:58
@cakebaker cakebaker force-pushed the find_make_inode_matcher_and_links_matcher_unix_only branch from 5e02694 to 0456e3a Compare May 29, 2024 09:05
@cakebaker cakebaker marked this pull request as ready for review May 29, 2024 09:09
@sylvestre sylvestre force-pushed the find_make_inode_matcher_and_links_matcher_unix_only branch from 0456e3a to a240606 Compare June 1, 2024 08:28
@sylvestre sylvestre force-pushed the find_make_inode_matcher_and_links_matcher_unix_only branch from a240606 to ee2159f Compare June 23, 2024 17:02
@sylvestre sylvestre force-pushed the find_make_inode_matcher_and_links_matcher_unix_only branch from ee2159f to cd0e119 Compare June 23, 2024 22:29
Copy link

GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105

@sylvestre
Copy link
Contributor

@hanbings maybe we should display it only when here are changes.
it will be too noisy otherwise

@hanbings
Copy link
Collaborator

@hanbings maybe we should display it only when here are changes. it will be too noisy otherwise

OK, I'll open a new PR to work on it.

@sylvestre sylvestre merged commit 42075f5 into uutils:main Jun 24, 2024
19 checks passed
@cakebaker cakebaker deleted the find_make_inode_matcher_and_links_matcher_unix_only branch June 24, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants