Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xargs: use #[allow(dead_code)] for enum #396

Merged
merged 1 commit into from
May 30, 2024

Conversation

cakebaker
Copy link
Contributor

This PR adds #[allow(dead_code)] to the CommandExecutionError enum to avoid a "variant Killed is never constructed" warning on Windows (see, for example, https://github.com/uutils/findutils/actions/runs/9298475960/job/25590452513?pr=395#step:6:201).

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.80%. Comparing base (3badb05) to head (52ee812).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   58.80%   58.80%           
=======================================
  Files          30       30           
  Lines        3855     3855           
  Branches      851      847    -4     
=======================================
  Hits         2267     2267           
  Misses       1254     1254           
  Partials      334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 0ca2450 into uutils:main May 30, 2024
17 of 18 checks passed
@cakebaker cakebaker deleted the xargs_allow_dead_code branch May 31, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants