Implement -fprintf
#444
Open
Implement -fprintf
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
+ Coverage 66.53% 66.57% +0.03%
==========================================
Files 36 36
Lines 4378 4404 +26
Branches 986 993 +7
==========================================
+ Hits 2913 2932 +19
- Misses 1063 1064 +1
- Partials 402 408 +6 ☔ View full report in Codecov by Sentry. |
|
Commit b5853cb has GNU testsuite comparison: |
|
needs rebasing |
|
Commit dc33ca5 has GNU testsuite comparison: |
|
Commit 67eb6f5 has GNU testsuite comparison: |
|
Commit 4ed3bc0 has GNU testsuite comparison: |
|
Commit 07e9b11 has GNU testsuite comparison: |
|
Commit 4130c38 has GNU testsuite comparison: |
|
Any idea why |
|
Commit 6f64a19 has GNU testsuite comparison: |
I guess it's something to do with the total number of GNU tests changing? But at least we know the code works. |
sylvestre
reviewed
Sep 9, 2024
Comment on lines
+625
to
+629
| if let Some(file) = &self.output_file { | ||
| self.print(file_info, file); | ||
| } else { | ||
| self.print(file_info, &mut *matcher_io.deps.get_output().borrow_mut()); | ||
| } |
There was a problem hiding this comment.
a bit more rust idiomatic:
Suggested change
| if let Some(file) = &self.output_file { | |
| self.print(file_info, file); | |
| } else { | |
| self.print(file_info, &mut *matcher_io.deps.get_output().borrow_mut()); | |
| } | |
| let output = self.output_file.as_ref() | |
| .unwrap_or_else(|| matcher_io.deps.get_output().borrow_mut()); | |
| self.print(file_info, output); |
There was a problem hiding this comment.
Wow, that's much cleaner.
I tried modifying it but I seem to be having some type issues.
error[E0308]: mismatched types
--> src/find/matchers/printf.rs:628:32
|
628 | .unwrap_or_else(|| matcher_io.deps.get_output().borrow_mut());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
expected `&File`, found `RefMut<'_, dyn Write>`
|
= note: expected reference `&File`
found struct `RefMut<'_, (dyn std::io::Write + 'static)>`
and I also tried:
fn print(&self, file_info: &WalkEntry, out: &mut dyn Write) { ... }
...
let output: &mut dyn Write = self.output_file
.as_ref()
.map(|file| file.borrow_mut() as &mut dyn Write)
.unwrap_or_else(|| matcher_io.deps.get_output().borrow_mut());
self.print(file_info, output);
...
I'm relatively new at this, would you mind pointing me out further?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #383