Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S24/trinity/adding navbar component #30

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

trinity-y
Copy link
Contributor

Notion ticket link

Create Shared Nav Bar

Implementation description

  • created navbar + related components (logo, profile + notification buttons)
  • created notification and profile pages
  • note: I got the logo from google so we should probably replace it eventually

Steps to test

  1. install react-icons

Test screenshots

Mobile
image image
Desktop
image
8e5a0602-ff2e-4bf7-a268-08efef2f8547

@trinity-y trinity-y marked this pull request as ready for review July 26, 2024 03:54
Copy link
Contributor

@aanxniee aanxniee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit but that than that, good to go! awesome work :)

frontend/public/images/humanesocietylogo.png Outdated Show resolved Hide resolved
frontend/src/components/common/navbar/Logo.tsx Outdated Show resolved Hide resolved
@aanxniee
Copy link
Contributor

i wonder if we should've set up tailwind 🤔 i forgot how annoying css is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants