Remove non PUBLISHED comment stage restrictions

[andrewyguo]

Notion ticket link

Remove non PUBLISHED comment stage restrictions

Implementation description

• Remove the first two restrictions

Steps to test

1. Reviewers and commenters should be able to leave comments on a story regardless of what stage it is in

What should reviewers focus on?

• idk, living a happy and meaningful life?

Checklist

• My PR name is descriptive and in imperative tense
• My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
• For backend changes, I have run the appropriate linters: docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ." and I have generated new migrations: flask db migrate -m "<your message>"
• I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

[gaoxk]

hmmm. So the goal of this ticket is to allow translators to leave comments on their translation, even if it's IN REVIEW (and vice versa for reviewers). I'm still getting errors when testing this scenario, and I think it's because of lines 48-50

if (story_translation_stage == "TRANSLATE" and is_translator) or (
            story_translation_stage == "REVIEW" and is_reviewer
        ):

the logic of this function needs to be reworked a little to something like this

if story_translation_stage == "PUBLISH" and (is_translator or is_reviewer):
            raise Exception(
            ...
elif  (is_translator or is_reviewer):
            try:
            ...
else:
            raise Exception("You are not authorized to leave comments on this story.")

Something I didnt think about: Comment panel is disabled when IN_REVIEW for translator, etc, even though we now want to allow translators to leave comments in such a state.

can you rip out the disabled prop & logic in CommentPanel?

apologies in advanced for ticket scope creep

[github-actions]

Visit the preview URL for this PR (updated for commit ae57acd):

https://planet-read-uwbp--pr228-remove-non-published-u99ortvc.web.app

_{(expires Thu, 30 Dec 2021 20:07:42 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[gaoxk]

noicee