Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change flexGrow to number #236

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Change flexGrow to number #236

merged 1 commit into from
Dec 23, 2021

Conversation

lynn-kim
Copy link
Member

@lynn-kim lynn-kim commented Dec 23, 2021

Notion ticket link

Ticket Name

Implementation description

Steps to test

What should reviewers focus on?

Fixes this bug!
image

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • For backend changes, I have run the appropriate linters: docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ." and I have generated new migrations: flask db migrate -m "<your message>"
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 6be8b09):

https://planet-read-uwbp--pr236-bug-statistic-flex-yhnb5sj4.web.app

(expires Thu, 30 Dec 2021 19:24:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@gaoxk gaoxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for proactivity!

@lynn-kim lynn-kim merged commit e96e11f into main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants