Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct story table link and stories query #264

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

gaoxk
Copy link
Contributor

@gaoxk gaoxk commented Dec 27, 2021

Implementation description

  • story link on manage stories table works now
    • couldnt find any other hrefs that dont follow our new /#/ pattern
  • homepage loads correctly. There is no dateUploaded field on the StoryTranslationDTO but I accidentally included it on Set up Manage Story page & table #243

Steps to test

  1. login as angela
  2. manage stories
  3. click links
  4. profit
  5. login as carl/any user
  6. load homepage
  7. profit

What should reviewers focus on?

  • is it lit

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • For backend changes, I have run the appropriate linters: docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ." and I have generated new migrations: flask db migrate -m "<your message>"
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit d8abd76):

https://planet-read-uwbp--pr264-fix-admin-stories-li-fm9x78kq.web.app

(expires Mon, 03 Jan 2022 02:07:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Collaborator

@jennchenn jennchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry must have missed this one in my PR 😞

@gaoxk
Copy link
Contributor Author

gaoxk commented Dec 27, 2021

all good! I think this got merged in after your pr, so no worries

1 similar comment
@gaoxk
Copy link
Contributor Author

gaoxk commented Dec 27, 2021

all good! I think this got merged in after your pr, so no worries

@gaoxk gaoxk merged commit fb6bfe7 into main Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants