Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getLanguages query #307

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Implement getLanguages query #307

merged 1 commit into from
Jan 3, 2022

Conversation

jennchenn
Copy link
Collaborator

@jennchenn jennchenn commented Jan 2, 2022

Notion ticket link

Implement getLanguages query

Implementation description

  • added query to get languages

Steps to test

  1. Rebuild containers and make sure database is up to date
  2. Run this query
  3. Verify response looks like:
{
  "data": {
    "languages": [
      "ARABIC",
      "ASANTE TWI",
      "ASSAMESE",
      "BENGALI",
      "BHILI",
      "CATALAN",
      "CHATINO",
      "DANISH",
      "DUTCH",
      "ENGLISH_UK",
      "ENGLISH_US",
      "ENGLISH_INDIAN",
      "ESPERANTO",
      "FRENCH",
      "GEORGIAN",
      "GERMAN",
      "GREEK",
      "GUJARATI",
      "HEBREW",
      "HINDI",
      "INDONESIAN",
      "ITALIAN",
      "JAPANESE",
      "KANNADA",
      "KAZAKH",
      "KHMER",
      "KOTAVA",
      "KURDISH",
      "KUTCHI",
      "LIDEPLA",
      "MALAYALAM",
      "MALTESE",
      "MANDARIN",
      "MARATHI",
      "NEPALI",
      "NORWEGIAN",
      "ORIYA",
      "POLISH",
      "PORTUGUESE",
      "PUNJABI",
      "ROMANIAN",
      "RUSSIAN",
      "SANSKRIT",
      "SANTALI",
      "SPANISH",
      "SWAHILI",
      "TAMANG",
      "TAMIL",
      "TELUGU",
      "TURKISH",
      "UKRAINIAN",
      "URDU"
    ]
  }
}

What should reviewers focus on?

  • does the query work as expected?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • For backend changes, I have run the appropriate linters: docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ." and I have generated new migrations: flask db migrate -m "<your message>"
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Contributor

@gaoxk gaoxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeeee 😎

@jennchenn jennchenn merged commit 0f2421b into main Jan 3, 2022
@jennchenn jennchenn deleted the language/get-languages branch January 3, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants