-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Process Story Service #315
Conversation
5e92d02
to
a90a38b
Compare
Visit the preview URL for this PR (updated for commit b973b7f): https://planet-read-uwbp--pr315-create-process-story-ot6xak7s.web.app (expires Tue, 11 Jan 2022 04:23:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
a90a38b
to
99f2497
Compare
4273777
to
6c68aa6
Compare
6c68aa6
to
17361e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotta meeting coming up, will test pr afterwards
edit: oops meant to hit "request changes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and worked as expected
d52d727
to
1b14c4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to merge after making changes. fyi theres no auth requirement on the mutation rn so this is the actual call to test:
curl http://localhost:5000/graphql -F operations='{"query": "mutation ($file: Upload!) { processStory(storyFile: $file) { storyContents }}","variables": {"file": null}}' -F map='{ "0": ["variables.file"]}' -F 0=@the_musical_donkey.docx
Notion ticket link
Ticket
Implementation description
Steps to test
Place this file in your root directory
test_story_file.docx
Log in as Angela Merkel on GQL and retrieve the auth_token, set the variable
auth_token
Run
curl http://localhost:5000/graphql -F operations='{"query": "mutation ($file: Upload!) { processStory(storyFile: $file) { storyContents }}","variables": {"file": null}}' -F map='{ "0": ["variables.file"]}' -F 0=@test_story_file.docx -H "Authorization: Bearer $auth_token"
This command should return the contents of the file
What should reviewers focus on?
Checklist
docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ."
and I have generated new migrations:flask db migrate -m "<your message>"