Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reset password refresh in BaseGQLClient #343

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Fix reset password refresh in BaseGQLClient #343

merged 1 commit into from
Jan 18, 2022

Conversation

gaoxk
Copy link
Contributor

@gaoxk gaoxk commented Jan 17, 2022

Notion ticket link

https://www.notion.so/uwblueprintexecs/Make-forget-password-work-716319eac5ca4a9a8a0b0a91b5087449

Implementation description

  • currently on main branch, the reset password feature just refreshes the page. this is due to the basegqlclient throwing out the request, like in Fixed signup #331
  • this is the last of all the auth mutations to not be considered in the basegqlclient

Steps to test

  1. go to signup
  2. input an email
  3. hit the forget password link
  4. observe alert
  5. check email, observe the reset password email from firebase

What should reviewers focus on?

  • happiness
  • staying hydrated
  • does it work

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • For backend changes, I have run the appropriate linters: docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ." and I have generated new migrations: flask db migrate -m "<your message>"
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@gaoxk gaoxk requested review from Puepis and lynn-kim January 17, 2022 01:17
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 1af3173):

https://planet-read-uwbp--pr343-fix-reset-p-word-cc4cvzkr.web.app

(expires Mon, 24 Jan 2022 01:23:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@jennifer-lu jennifer-lu self-requested a review January 18, 2022 13:12
Copy link
Member

@jennifer-lu jennifer-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
All testing steps work well; am happy and hydrated now

@gaoxk
Copy link
Contributor Author

gaoxk commented Jan 18, 2022

glad u r happy n hydrated!

@gaoxk gaoxk merged commit d15961e into main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants