Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide 'remove myself from translation' if admin viewing platform #375

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

jennifer-lu
Copy link
Member

Notion ticket link

Hide “remove myself from translation” if admin viewing platform

Implementation description

  • Hid “remove myself from translation” on review page if user is not the reviewer

Steps to test

  1. Login as Angela Merkel
  2. Go to a translation
  3. Observe that “remove myself from translation” link is not there

What should reviewers focus on?

  • Does it work?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • For backend changes, I have run the appropriate linters: docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ." and I have generated new migrations: flask db migrate -m "<your message>"
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 8f4bc09):

https://planet-read-uwbp--pr375-fix-hide-remove-z6fu4c2i.web.app

(expires Tue, 22 Feb 2022 20:21:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@gaoxk gaoxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! apologies for late review

@jennifer-lu
Copy link
Member Author

nice! apologies for late review

No worries at all! Thank you for the review :D

@jennifer-lu jennifer-lu merged commit d151d66 into main Feb 16, 2022
@jennifer-lu jennifer-lu deleted the fix/hide-remove branch February 16, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants