Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tab links #378

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Fix broken tab links #378

merged 2 commits into from
Feb 20, 2022

Conversation

jennchenn
Copy link
Collaborator

@jennchenn jennchenn commented Feb 18, 2022

Notion ticket link

Implementation description

Steps to test

  1. Go to the prod site
  2. Login as admin; click around on the tabs and verify that they redirect you as expected
  3. Login as a regular user; click around on the tabs and verify that they redirect you as expected

What should reviewers focus on?

  • any other places to change?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • For backend changes, I have run the appropriate linters: docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ." and I have generated new migrations: flask db migrate -m "<your message>"
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

github-actions bot commented Feb 18, 2022

Visit the preview URL for this PR (updated for commit 55421aa):

https://planet-read-uwbp--pr378-bug-tab-links-dqtbarls.web.app

(expires Fri, 25 Feb 2022 17:22:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@jennchenn jennchenn marked this pull request as ready for review February 18, 2022 09:38
@jennchenn jennchenn requested a review from gaoxk February 18, 2022 09:40
@jennchenn jennchenn force-pushed the bug/tab-links branch 2 times, most recently from fc06a8e to 5f9a659 Compare February 18, 2022 09:52
Copy link
Contributor

@gaoxk gaoxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! couldnt think of any other links. ty for your proactivity!

@@ -8,7 +8,7 @@
<meta name="theme-color" content="#000000" />
<meta
name="description"
content="Web site created using create-react-app"
content="Add My Language is a volunteer-driven activity where people help us in making stories in their native languages."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this copy officially from planet read? if not, change to "Add My Language is a volunteer-driven program where volunteers translate stories to their native languages." imo flows better

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo i took it from here:

"Add My Language is a volunteer-driven activity where people help us in making stories in their native languages.",

do you want me to change it? (or is there any copy they want to use for the app description?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennchenn ahh i see, no need to change!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go ahead and merge :)

@jennchenn jennchenn merged commit d7273c7 into main Feb 20, 2022
@jennchenn jennchenn deleted the bug/tab-links branch February 20, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants