-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken tab links #378
Fix broken tab links #378
Conversation
Visit the preview URL for this PR (updated for commit 55421aa): https://planet-read-uwbp--pr378-bug-tab-links-dqtbarls.web.app (expires Fri, 25 Feb 2022 17:22:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
270ed60
to
a093b91
Compare
fc06a8e
to
5f9a659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! couldnt think of any other links. ty for your proactivity!
@@ -8,7 +8,7 @@ | |||
<meta name="theme-color" content="#000000" /> | |||
<meta | |||
name="description" | |||
content="Web site created using create-react-app" | |||
content="Add My Language is a volunteer-driven activity where people help us in making stories in their native languages." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is this copy officially from planet read? if not, change to "Add My Language is a volunteer-driven program where volunteers translate stories to their native languages." imo flows better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo i took it from here:
"Add My Language is a volunteer-driven activity where people help us in making stories in their native languages.", |
do you want me to change it? (or is there any copy they want to use for the app description?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jennchenn ahh i see, no need to change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go ahead and merge :)
Notion ticket link
Implementation description
Steps to test
What should reviewers focus on?
Checklist
docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ."
and I have generated new migrations:flask db migrate -m "<your message>"