Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for test and MySQL migration #64

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

e-wai
Copy link
Collaborator

@e-wai e-wai commented Aug 11, 2021

Implementation description

Steps to test

  1. Not really, I just wanted to play with in-browser VScode

What should reviewers focus on?

  • Makes sense? Missing anything?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • For backend changes, I have run the appropriate linters: docker exec -it <backend-container-id> /bin/bash -c "black . && isort --profile black ."
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@e-wai e-wai requested a review from gaoxk August 11, 2021 23:45
@e-wai e-wai merged commit b9722a7 into main Aug 13, 2021
@e-wai e-wai deleted the readme-updates branch August 13, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants