Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuke: remove useless pages and REST API #73

Merged
merged 1 commit into from
Aug 24, 2021
Merged

nuke: remove useless pages and REST API #73

merged 1 commit into from
Aug 24, 2021

Conversation

gaoxk
Copy link
Contributor

@gaoxk gaoxk commented Aug 24, 2021

Notion ticket link

NUKE IT LOL

Implementation description

  • removed REST API
  • removed all entity related models, mutations, queries, services
  • removed default useless frontend pages and components

Steps to test

  1. login
  2. poke around
  3. ???
  4. profit

What should reviewers focus on?

  • just make sure our app still works lmfao

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • For backend changes, I have run the appropriate linters: docker exec -it <backend-container-id> /bin/bash -c "black . && isort --profile black ."
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Collaborator

@andrewyguo andrewyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seemed to be broken 😎

Remember to pull the recent PR from main!

@gaoxk
Copy link
Contributor Author

gaoxk commented Aug 24, 2021

TFTR!

@gaoxk gaoxk merged commit d410424 into main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants