Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health check to docker-compose.yml #10

Merged
merged 1 commit into from
Oct 3, 2021
Merged

Add health check to docker-compose.yml #10

merged 1 commit into from
Oct 3, 2021

Conversation

7tint
Copy link
Member

@7tint 7tint commented Oct 2, 2021 •
edited
Loading

Ticket link

Closes #1

Implementation description

  • Added a DB health check to the docker-compose.yml file.

Steps to test

  1. Start up docker containers a few times and make sure that the PostgreSQL database is up.

What should reviewers focus on?

  • Correct implementation and functionality of the db health check

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@7tint 7tint requested review from sherryhli and a team and removed request for a team October 2, 2021 23:12
sherryhli
sherryhli approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Nit: please capitalize the commit message and the PR title in the future :)

@sherryhli sherryhli changed the title add health check to docker-compose.yml Add health check to docker-compose.yml Oct 3, 2021
@7tint 7tint changed the title Add health check to docker-compose.yml Add Health Check to docker-compose.yml Oct 3, 2021
@7tint 7tint changed the title Add Health Check to docker-compose.yml Add health check to docker-compose.yml Oct 3, 2021
@7tint 7tint merged commit 61bc03a into main Oct 3, 2021
@7tint 7tint deleted the docker-db-healthcheck branch October 3, 2021 14:02
sherryhli pushed a commit that referenced this pull request Jan 6, 2022
@7tint
add health check to docker-compose.yml (#10)
4e413e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherryhli sherryhli sherryhli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add db health check in docker-compose.yml
2 participants
@7tint @sherryhli