-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement type safe error handling #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some cases where the error is being explicitly typed as any
, do you mind addressing those too? They're flagged by the linter github actions workflow.
The rest looks good!
Just fixed this up. 🔨 Should we do anything about the |
@lambo-liu Yes, let's type them as |
@sherryhli Should be good now! Let me know if there is anything else we need to patch up 🪡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket link
Closes #99
Implementation description
getErrorMessage
utility functionunknown
getErrorMessage
Steps to test
What should reviewers focus on?
Checklist