Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove availability and prereq table from schema #106

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Remove availability and prereq table from schema #106

merged 1 commit into from
Jan 30, 2022

Conversation

MatoPlus
Copy link
Member

@MatoPlus MatoPlus commented Jan 28, 2022 •
edited
Loading

Ticket link

Closes #94

Implementation description

  • Remove deprecated tables
  • Add migration file via npx prisma migrate dev --name remove_availability_and_prereq
  • Add sample instruction to readme regarding migration files

Steps to test

  1. App still runs, user can still log in as needed

What should reviewers focus on?

  • If there are any missing fields left
  • If generated migration file is okay
  • If readme is okay

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@MatoPlus MatoPlus marked this pull request as ready for review January 28, 2022 01:21
LenaNguyen
LenaNguyen approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatoPlus MatoPlus merged commit 68072f1 into main Jan 30, 2022
@MatoPlus MatoPlus deleted the rickson/remove-availabilities-prereq branch January 30, 2022 20:29
@sherryhli sherryhli mentioned this pull request Jan 30, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenaNguyen LenaNguyen LenaNguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove availabilities and prerequisites tables
2 participants
@MatoPlus @LenaNguyen