Add filtering by status to signups #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket link
Closes #126
Implementation description
getShiftSignupsForUser
endpoint, I added an optional argument for specifying the status of the signup.getShiftSignupsForUser(id)
->getShiftSignupsForUser(id, status)
Steps to test
mutation { createShiftSignups( shifts: [{ shiftId: 3, userId: 1, numVolunteers: 3, note: "test" }] ) { shiftId userId numVolunteers note } }
What should reviewers focus on?
Checklist