Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering by status to signups #163

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Conversation

hujoseph99
Copy link
Contributor

Ticket link

Closes #126

Implementation description

  • To add filtering by signups to our getShiftSignupsForUser endpoint, I added an optional argument for specifying the status of the signup.
    • getShiftSignupsForUser(id) -> getShiftSignupsForUser(id, status)

Steps to test

  1. You can populate the db into a testable state by running the commands found in this PR
  2. Create some signups using mutations. For example: mutation { createShiftSignups( shifts: [{ shiftId: 3, userId: 1, numVolunteers: 3, note: "test" }] ) { shiftId userId numVolunteers note } }
  3. Test various scenarios to see if the filtering works as expected.

What should reviewers focus on?

  • Test to see if the filtering works as behaved.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@hujoseph99 hujoseph99 requested a review from a team February 20, 2022 05:52
Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hujoseph99 hujoseph99 merged commit 14cf972 into main Feb 20, 2022
@hujoseph99 hujoseph99 deleted the joseph/signups-by-status branch February 20, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volunteer Signups By Status (Backend)
2 participants