-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Nested Fields in isAuthorizedByUserId for Retrieving UserId #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is just me, but it seems like the authorization checks aren't working now? I was able to create a shift for any user but also with any role 🤔 Not sure what's happening yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works great now! Thank you for looking into this! Just some tips on optimizing the code but aside from that it's looking good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket link
Closes #115
Implementation description
isAuthorizedForCreateShiftSignups
check forcreateShiftSignups
andisAuthorizedForUpdateShiftSignups
check forupdateShiftSignup
Steps to test
docker-compose up --build
Sign in as a volunteer and use the access token for the following mutations:
Sign in as an admin and use the access token for the following mutations:
Sign in as an employee and use the access token for the following mutations:
What should reviewers focus on?
Checklist