Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Sistering logo to use svg in volunteer navbar #198

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

briantu
Copy link
Member

@briantu briantu commented Mar 6, 2022

Ticket link

Closes #125

Implementation description

  • Changed Sistering logo to the svg format

Steps to test

  1. Go to /volunteer/shifts or /volunteer/postings and check that the logo in the volunteer navbar is an svg

What should reviewers focus on?

  • Logo and spacing look good

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@briantu briantu requested a review from LenaNguyen March 6, 2022 22:01
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

Visit the preview URL for this PR (updated for commit 9dbef8d):

https://sistering-dev--pr198-brian-use-svg-logo-i-4u558iqg.web.app

(expires Sun, 13 Mar 2022 22:05:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briantu briantu merged commit e7f852f into main Mar 7, 2022
@briantu briantu deleted the brian/use-svg-logo-in-navbar branch March 7, 2022 15:44
MatoPlus pushed a commit that referenced this pull request Mar 8, 2022
* Change sistering logo to svg

* Fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volunteer Navbar
2 participants