Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volunteer select availability table #200

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

MatoPlus
Copy link
Member

@MatoPlus MatoPlus commented Mar 8, 2022

Ticket link

Closes #120, #119, #129

Implementation description

image

  • Add volunteer select availability table
  • Enhanced base components for better padding, highlighted background on select, disabled input when not selected

TODO:

  • change prop type from postingId to posting type (@uwblueprint/sistering-w22-pls I'm not sure what type I should use here). This can honestly be done in the integration step

Steps to test

  1. Play around with the test page on the volunteer/posting route
  2. input should be disabled if shift checkbox is not selected
  3. background should highlight when shift selected
  4. page should display current week from sun to sat correctly with appropriate shifts in each table section

What should reviewers focus on?

  • Design: look and feel
  • Dev: Implementation of table

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@MatoPlus MatoPlus force-pushed the rickson/volunteer-select-availability-table branch from d88be07 to 75ebbf4 Compare March 8, 2022 03:14
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Visit the preview URL for this PR (updated for commit b1b95ea):

https://sistering-dev--pr200-rickson-volunteer-se-gye7lbg5.web.app

(expires Mon, 04 Apr 2022 17:51:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@MatoPlus MatoPlus force-pushed the rickson/volunteer-select-availability-table branch 2 times, most recently from 2c4b091 to 9fa719d Compare March 11, 2022 01:09
LenaNguyen
LenaNguyen previously approved these changes Mar 13, 2022
@MatoPlus MatoPlus force-pushed the rickson/volunteer-select-availability-table branch 2 times, most recently from fe7d299 to b932888 Compare March 28, 2022 17:45
MatoPlus and others added 3 commits March 28, 2022 13:46
* Add volunteer select availability table

* temp headers implementation

* Add working logic to table header

* Fix styling of table

* Cleanup code + fix week diff

* Volunteer select availability table datafetch newpage (#210)

* Add fetch page and table tweak

* Add query for posting info proper props

* Finish Select Shift page with top level state

* Add shift by posting + note perserve
@MatoPlus MatoPlus force-pushed the rickson/volunteer-select-availability-table branch from b932888 to b1b95ea Compare March 28, 2022 17:47
@MatoPlus MatoPlus requested a review from LenaNguyen March 28, 2022 17:47
@MatoPlus MatoPlus merged commit f76e23d into main Mar 28, 2022
@MatoPlus MatoPlus deleted the rickson/volunteer-select-availability-table branch March 28, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volunteer Select Availability Table
3 participants