-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create admin schedule review table #206
Conversation
Visit the preview URL for this PR (updated for commit 47eafa0): https://sistering-dev--pr206-lambert-schedule-rev-gzcm6kx1.web.app (expires Thu, 07 Apr 2022 23:00:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for UI changes can you pls add a demo on the default page or something next time 🙏 my docker takes a million years to start so sometimes it's much faster to use the firebase preview. The downside is you'd have to remove it after get another approval tho.
Actually idk if this is that important @sherryhli . If we change the theme to accommodate for this padding then other places where we use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🔥 Some small code improvement suggestions and a minor UI deviation, LGTM otherwise!
frontend/src/components/admin/schedule/AdminScheduleTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/admin/schedule/AdminScheduleTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/admin/schedule/AdminScheduleTableRow.tsx
Outdated
Show resolved
Hide resolved
@LenaNguyen Yeah I'm for staying consistent to a single theme variant if possible, could we check with design to see if this small deviation is okay? |
Just realized something: with the way we plan on fetching data for the schedule creation frontend (running a query on the signups table rather than shifts), we wouldn't know about any shifts without signups. That means the row type below would not be seen, and the shift would also not be shown as a dot in the calendar. cc @JoshuaYe @LenaNguyen Do you have any input on the necessity and priority of this feature? How useful is it to view shifts that do not have any signups in schedule creation? (@lambo-liu no change needed for now, please keep this row type in the code) |
It seems useful to know that there are some shifts that no one is registered for in the overview |
cf42fbf
to
2884b4f
Compare
cf5154d
to
47eafa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket link
Closes #156
Closes #158
Implementation description
Steps to test
Default.tsx
, importing components/variables when necessary:TableTestData
is rendered correctly. The test data includes three types of table rows, as specified in Schedule review table row #156.What should reviewers focus on?
Checklist