Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denormalize signup res and query types #221

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Denormalize signup res and query types #221

merged 1 commit into from
Mar 21, 2022

Conversation

MatoPlus
Copy link
Member

@MatoPlus MatoPlus commented Mar 18, 2022 •
edited
Loading

Ticket link

Closes #195

Implementation description

  • Denormalize typing as required
  • Add new converter method for denormalized response type

Steps to test

NOTE: This PR has not been tested yet. would like some quick pointers

What should reviewers focus on?

  • correctness

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@MatoPlus MatoPlus changed the title Denormalize signup res and query typesl Denormalize signup res and query types Mar 18, 2022
@MatoPlus MatoPlus force-pushed the rickson/denormalize-shift-start-end-times-onto-shiftSignUpRes branch 2 times, most recently from d7bacc3 to 981f3e9 Compare March 18, 2022 02:11
@MatoPlus MatoPlus marked this pull request as ready for review March 18, 2022 02:13
@MatoPlus MatoPlus force-pushed the rickson/denormalize-shift-start-end-times-onto-shiftSignUpRes branch from 981f3e9 to 4c99759 Compare March 18, 2022 02:15
@MatoPlus MatoPlus force-pushed the rickson/denormalize-shift-start-end-times-onto-shiftSignUpRes branch from 4c99759 to 1606580 Compare March 20, 2022 18:21
LenaNguyen
LenaNguyen approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@MatoPlus MatoPlus merged commit 7f92731 into main Mar 21, 2022
@MatoPlus MatoPlus deleted the rickson/denormalize-shift-start-end-times-onto-shiftSignUpRes branch March 21, 2022 22:43
LenaNguyen pushed a commit that referenced this pull request Mar 24, 2022
@MatoPlus @LenaNguyen
Denormalize signup res and query types (#221)
c271c42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenaNguyen LenaNguyen LenaNguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Denormalize shift start and end times onto ShiftSignupResponse
2 participants
@MatoPlus @LenaNguyen